Issue 8448006: Move PEG parser test into testing framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8448006: Move PEG parser test into testing framework. (Closed)

Created:
9 years, 1 month ago by sra1

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Move PEG parser test into testing framework. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1177

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed empty section #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -348 lines)			Patch
D	utils/peg/pegparser_test.dart	View		1 chunk	+0 lines, -346 lines	0 comments	Download
A	utils/tests/peg/peg.status	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	utils/tests/peg/src/PegTest.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	utils/tests/peg/testcfg.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

9 years, 1 month ago (2011-11-03 22:22:54 UTC) #2

lgtm

make sure to run ./tools/presubmit.sh (note this is the one in the main dart
tree) to make sure it all works ok.

http://codereview.chromium.org/8448006/diff/1/utils/tests/peg/peg.status
File utils/tests/peg/peg.status (right):

http://codereview.chromium.org/8448006/diff/1/utils/tests/peg/peg.status#newc...
utils/tests/peg/peg.status:10: [ $component == vm && $mode == debug ]
you should be able to delete this line, but then make sure that running test.py
--component=vm works

Expand Messages | Collapse Messages