Issue 8440065: Simulate VM behavior wrt open receive ports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8440065: Simulate VM behavior wrt open receive ports. (Closed)

Created:
9 years, 1 month ago by floitsch

Modified:
9 years, 1 month ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Simulate VM behavior wrt open receive ports. VM times out. DartC now exits with exception. Committed: https://code.google.com/p/dart/source/detail?r=1146

Patch Set 2 : Address comment. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	compiler/lib/implementation/isolate.js	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. http://codereview.chromium.org/8440065/diff/1/compiler/lib/implementation/isolate.js File compiler/lib/implementation/isolate.js (right): http://codereview.chromium.org/8440065/diff/1/compiler/lib/implementation/isolate.js#newcode391 compiler/lib/implementation/isolate.js:391: } else if (isolate$isolateRegistry.get(isolate$rootIsolate.id) && I would compare ...

9 years, 1 month ago (2011-11-03 13:16:00 UTC) #2

floitsch

9 years, 1 month ago (2011-11-03 13:28:53 UTC) #3

http://codereview.chromium.org/8440065/diff/1/compiler/lib/implementation/iso...
File compiler/lib/implementation/isolate.js (right):

http://codereview.chromium.org/8440065/diff/1/compiler/lib/implementation/iso...
compiler/lib/implementation/isolate.js:391: } else if
(isolate$isolateRegistry.get(isolate$rootIsolate.id) &&
On 2011/11/03 13:16:00, kasperl wrote:
> I would compare this against null.

added .contains method.

Expand Messages | Collapse Messages

Issue 8440065: Simulate VM behavior wrt open receive ports. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages