Issue 8440057: - Add an Options interface to the core library. The core library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8440057: - Add an Options interface to the core library. The core library (Closed)

Created:
9 years, 1 month ago by Ivan Posva

Modified:
9 years, 1 month ago

Reviewers:
dgrove, sra1, siva, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/corelib/

Visibility:
Public.

Description

- Add an Options interface to the core library. The core library implementation and the execution environment provide the implementation and the values. Committed: https://code.google.com/p/dart/source/detail?r=1168

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/corelib_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	src/options.dart	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

This change adds the interface as discussed a long while ago. -Ivan

9 years, 1 month ago (2011-11-03 00:27:40 UTC) #1

sra1

http://codereview.chromium.org/8440057/diff/1/src/options.dart File src/options.dart (right): http://codereview.chromium.org/8440057/diff/1/src/options.dart#newcode15 src/options.dart:15: List<String> get arguments(); Please specify: Is the returned list ...

9 years, 1 month ago (2011-11-03 04:12:44 UTC) #3

Ivan Posva

9 years, 1 month ago (2011-11-03 21:44:09 UTC) #4

http://codereview.chromium.org/8440057/diff/1/src/options.dart
File src/options.dart (right):

http://codereview.chromium.org/8440057/diff/1/src/options.dart#newcode15
src/options.dart:15: List<String> get arguments();
Updated comments.

-Ivan

On 2011/11/03 04:12:44, sra1 wrote:
> Please specify:
> 
> Is the returned list mutable?
> Is the list shared between calls to opts.arguments ?
> Is it shared between different instances of new Options() ?
> 
> The answers to these questions will tell me when need to make a copy, and if I
> can adjust the arguments seen by other components running the isolate.

Expand Messages | Collapse Messages