Issue 8440051: Intrinsify String.charCodeAt, String.length and String.hashCode. Improves frog performance by 2x.

Issue 8440051: Intrinsify String.charCodeAt, String.length and String.hashCode. Improves frog performance by 2x. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Intrinsify String.charCodeAt, String.length and String.hashCode. Improves frog performance by 2x. Committed: https://code.google.com/p/dart/source/detail?r=1120

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
M	runtime/vm/intrinsifier_ia32.cc	View	1 2	2 chunks	+48 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32.cc File runtime/vm/intrinsifier_ia32.cc (right): http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32.cc#newcode904 runtime/vm/intrinsifier_ia32.cc:904: __ movl(EAX, Address(ESP, + 1 * kWordSize)); // ...

9 years, 1 month ago (2011-11-02 20:22:06 UTC) #2

srdjan

9 years, 1 month ago (2011-11-02 20:31:42 UTC) #3

http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32.cc
File runtime/vm/intrinsifier_ia32.cc (right):

http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32...
runtime/vm/intrinsifier_ia32.cc:904: __ movl(EAX, Address(ESP, + 1 *
kWordSize));
On 2011/11/02 20:22:06, asiva wrote:
> // String object.

Done.

http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32...
runtime/vm/intrinsifier_ia32.cc:916: __ movl(EAX, Address(ESP, + 2 *
kWordSize));  // Array.
On 2011/11/02 20:22:06, asiva wrote:
> // String object. (not Array)

Done.

http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32...
runtime/vm/intrinsifier_ia32.cc:938: __ movl(EAX, Address(ESP, + 1 *
kWordSize));
On 2011/11/02 20:22:06, asiva wrote:
> // String object.

Done.

http://codereview.chromium.org/8440051/diff/2002/runtime/vm/intrinsifier_ia32...
runtime/vm/intrinsifier_ia32.cc:941: __ j(EQUAL, &fall_through,
Assembler::kNearJump);
On 2011/11/02 20:22:06, asiva wrote:
> // Hash not computed yet.

Done.

Expand Messages | Collapse Messages