Issue 8440023: Deoptimization tests for instance field increment optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8440023: Deoptimization tests for instance field increment optimization. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

Description

Deoptimization tests for instance field increment optimization. Committed: https://code.google.com/p/dart/source/detail?r=1096

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
	A	language/src/InstanceIncrDeoptTest.dart	View	1 2 3	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8440023/diff/2001/language/src/InstanceIncrDeoptTest.dart File language/src/InstanceIncrDeoptTest.dart (right): http://codereview.chromium.org/8440023/diff/2001/language/src/InstanceIncrDeoptTest.dart#newcode24 language/src/InstanceIncrDeoptTest.dart:24: Expect.equals(1.0, b.f); Do you use a double for ...

9 years, 1 month ago (2011-11-02 02:06:37 UTC) #2

srdjan

9 years, 1 month ago (2011-11-02 15:10:55 UTC) #3

http://codereview.chromium.org/8440023/diff/2001/language/src/InstanceIncrDeo...
File language/src/InstanceIncrDeoptTest.dart (right):

http://codereview.chromium.org/8440023/diff/2001/language/src/InstanceIncrDeo...
language/src/InstanceIncrDeoptTest.dart:24: Expect.equals(1.0, b.f);
On 2011/11/02 02:06:37, regis wrote:
> Do you use a double for a particular reason? b.f holds an int.

Good catch, this would fail in type checked mode. Changed field f to var. I am
setting f to double so that the type assumption at ++(expecting Smi) is
invalidated and deoptimization occurs.

Expand Messages | Collapse Messages

Issue 8440023: Deoptimization tests for instance field increment optimization. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages