Issue 8439067: Implement fullPath method on File objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8439067: Implement fullPath method on File objects. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Implement fullPath method on File objects. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1134

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -25 lines)			Patch
M	runtime/bin/builtin_in.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View		5 chunks	+44 lines, -0 lines	0 comments	Download
M	tests/standalone/src/FileTest.dart	View	1	2 chunks	+37 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/8439067/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (right): http://codereview.chromium.org/8439067/diff/1/tests/standalone/src/FileTest.dart#newcode147 tests/standalone/src/FileTest.dart:147: file.fullPathHandler = (s) { Maybe check that s ...

9 years, 1 month ago (2011-11-03 08:07:53 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-03 10:18:26 UTC) #3

http://codereview.chromium.org/8439067/diff/1/tests/standalone/src/FileTest.dart
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/8439067/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:147: file.fullPathHandler = (s) {
On 2011/11/03 08:07:53, Søren Gjesse wrote:
> Maybe check that s is not just outFilenameBase + "_out", and maybe that it
> starts with either "/" ot "\" or that the second char is ":".

Done.

http://codereview.chromium.org/8439067/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:210: Expect.isTrue(new
File(path).existsSync());
On 2011/11/03 08:07:53, Søren Gjesse wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages

Issue 8439067: Implement fullPath method on File objects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments. #

Messages