Restructure instance setter and finish the last 1/3 of increment instance field optimization.

Restructure instance setter and finish the last 1/3 of increment instance field optimization.
Committed: https://code.google.com/p/dart/source/detail?r=1159

[siva, 2011-11-03 17:02:29]

lgtm

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1134: for (int i = 0; i <
a.NumberOfChecks(); i++) {
In the loop above (printCollectedClassesAtId(...) the for loop uses intptr_t i,
I guess here too it should be intptr_t

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1137: for (int n = 0; n <
b.NumberOfChecks(); n++) {
Ditto comment regarding intptr_t

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1442: // Returns stored value in
'value_reg'.
Should the comment say 'recv_reg' and 'value_reg' values are not clobbered.
EBX register is clobbered.

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1453: }
Instead of this unimplemented why not just assert
recv_reg != EBX and value_reg != EBX and use
recv_reg in place of EDX and value_reg in place of EAX in
the code below?

[srdjan, 2011-11-03 18:36:13]

Thanks!

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1134: for (int i = 0; i <
a.NumberOfChecks(); i++) {
On 2011/11/03 17:02:29, asiva wrote:
> In the loop above (printCollectedClassesAtId(...) the for loop uses intptr_t
i,
> I guess here too it should be intptr_t

Done.

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1137: for (int n = 0; n <
b.NumberOfChecks(); n++) {
On 2011/11/03 17:02:29, asiva wrote:
> Ditto comment regarding intptr_t

Done.

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1442: // Returns stored value in
'value_reg'.
On 2011/11/03 17:02:29, asiva wrote:
> Should the comment say 'recv_reg' and 'value_reg' values are not clobbered.
> EBX register is clobbered.

Added Clobber EBX, 'value_reg' untouched.
Don't care about recv_reg at the moment.

http://codereview.chromium.org/8439059/diff/6001/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1453: }
On 2011/11/03 17:02:29, asiva wrote:
> Instead of this unimplemented why not just assert
> recv_reg != EBX and value_reg != EBX and use
> recv_reg in place of EDX and value_reg in place of EAX in
> the code below?

Done.