Issue 8439023: Optimize 2/3 of instance field increment operation.

Issue 8439023: Optimize 2/3 of instance field increment operation. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

Optimize 2/3 of instance field increment operation. Committed: https://code.google.com/p/dart/source/detail?r=1097

Patch Set 8 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -79 lines)			Patch
M	vm/code_generator_ia32.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/opt_code_generator_ia32.h	View	1 2 3 4 5	3 chunks	+11 lines, -2 lines	0 comments	Download
M	vm/opt_code_generator_ia32.cc	View	1 2 3 4 5 6 7	13 chunks	+182 lines, -76 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.cc File vm/opt_code_generator_ia32.cc (right): http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.cc#newcode563 vm/opt_code_generator_ia32.cc:563: ic_data.NumberOfChecks() != 1) { Missing 2 pairs of ...

9 years, 1 month ago (2011-11-02 02:02:54 UTC) #2

srdjan

9 years, 1 month ago (2011-11-02 15:26:20 UTC) #3

http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.cc
File vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.c...
vm/opt_code_generator_ia32.cc:563: ic_data.NumberOfChecks() != 1) {
On 2011/11/02 02:02:54, regis wrote:
> Missing 2 pairs of parenthesis.

Done.

http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.c...
vm/opt_code_generator_ia32.cc:1122: const bool has_pre_inc_result =
!node->prefix() && IsResultNeeded(node);
On 2011/11/02 02:02:54, regis wrote:
> The name of the flag is a bit confusing, "has_pre" indicates "not a prefix
> operator".

Changed to : return_original_value

http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.c...
vm/opt_code_generator_ia32.cc:1123: const Immediate one_value =
Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
On 2011/11/02 02:02:54, regis wrote:
> You can hide the cast with Immediate(Smi::RawValue(1))

Done.

http://codereview.chromium.org/8439023/diff/6008/vm/opt_code_generator_ia32.c...
vm/opt_code_generator_ia32.cc:1306: // inlineable getter targe.
On 2011/11/02 02:02:54, regis wrote:
> target

Done.

Expand Messages | Collapse Messages