Test implicit this on fields.

Test implicit this on fields.

Committed: https://code.google.com/p/dart/source/detail?r=1289

[kasperl, 2011-11-02 09:03:00]

LGTM.

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
dart/tests/language/src/ImplicitThisTest.dart:9: class Abstract implements
Interface {
Maybe add a comment here. Something like: If you say you implement an interface
but you really don't, it means that you're an abstract class that cannot be
instantiated.

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
dart/tests/language/src/ImplicitThisTest.dart:17: class SubConcrete extends
Abstract {
How about ConcreteA and ConcreteB? They are not related.

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
dart/tests/language/src/ImplicitThisTest.dart:25: Expect.equals(new
Concrete().toString(), '7');
expected, actual

[gbracha, 2011-11-02 19:01:45]

I don't think this test is quite sensible. See my comments. Probably the
re-opening of a big discussion.

http://codereview.chromium.org/8438032/diff/2001/dart/tests/language/src/Impl...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/2001/dart/tests/language/src/Impl...
dart/tests/language/src/ImplicitThisTest.dart:23: var x = new Abstract(); ///
01: static type error
Why do you expect a static warning here? Class Abstract is a concrete class. It
does not declare an abstract method. What I would expect would be a static
warning on the declaration of Abstract, saying that it does not in fact
implement the getter x of Interface. Mind you, it looks like the spec doesn't 
make this clear.   We should implement the abstract modifier for classes as well
to make al this run smoothly.

[ahe, 2011-11-02 19:03:57]

Hi Gilad,

Thank you for taking a look.

Cheers,
Peter

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/1/dart/tests/language/src/Implici...
dart/tests/language/src/ImplicitThisTest.dart:17: class SubConcrete extends
Abstract {
On 2011/11/02 09:03:00, kasperl wrote:
> How about ConcreteA and ConcreteB? They are not related.

But they are, I just subclassed the wrong class. Good catch :-)

http://codereview.chromium.org/8438032/diff/2001/dart/tests/language/src/Impl...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/2001/dart/tests/language/src/Impl...
dart/tests/language/src/ImplicitThisTest.dart:23: var x = new Abstract(); ///
01: static type error
On 2011/11/02 19:01:45, gbracha wrote:
> Why do you expect a static warning here? Class Abstract is a concrete class.
It
> does not declare an abstract method. What I would expect would be a static
> warning on the declaration of Abstract, saying that it does not in fact
> implement the getter x of Interface. Mind you, it looks like the spec doesn't 
> make this clear.   We should implement the abstract modifier for classes as
well
> to make al this run smoothly.

Good point. I should add the abstract keyword to the class Abstract.

[ahe, 2011-11-07 15:15:16]

Hi Kasper and Gilad,

Please take another look.

Cheers,
Peter

[kasperl, 2011-11-07 15:27:37]

LGTM.

http://codereview.chromium.org/8438032/diff/5001/dart/tests/language/src/Impl...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/5001/dart/tests/language/src/Impl...
dart/tests/language/src/ImplicitThisTest.dart:11: // must be marked abstract.
... because it doesn't implement the x getter.

[gbracha, 2011-11-07 21:23:26]

lgtm

[ahe, 2011-11-08 09:02:29]

Thank you.

http://codereview.chromium.org/8438032/diff/5001/dart/tests/language/src/Impl...
File dart/tests/language/src/ImplicitThisTest.dart (right):

http://codereview.chromium.org/8438032/diff/5001/dart/tests/language/src/Impl...
dart/tests/language/src/ImplicitThisTest.dart:11: // must be marked abstract.
On 2011/11/07 15:27:37, kasperl wrote:
> ... because it doesn't implement the x getter.

Done.

[ahe, 2011-11-08 09:03:41]

Shoot. I forgot to file bugs. I'll follow up with another CL.