- Update tests to make sure they recerefence invalid code.

- Update tests to make sure they recerefence invalid code.
- Improve multi test case configuration by adding a 'continued' tag.
Committed: https://code.google.com/p/dart/source/detail?r=1153

[ahe, 2011-11-03 16:16:45]

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix13NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix13NegativeTest.dart:10: class MyClass extends
lib12.Library13 {
Is this change necessary?

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix15NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix15NegativeTest.dart:10: class MyClass implements
lib12.Library13 {
Necessary?

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix18NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix18NegativeTest.dart:11: lib1.invalid.foo();
Not sure this should be needed.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix19NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix19NegativeTest.dart:8: #import("library1.dart",
prefix:"$lib1");
This sucks. If this is indeed an error, then see the previous file.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Script2...
File dart/tests/language/src/Script2NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Script2...
dart/tests/language/src/Script2NegativeTest.dart:11: new A().a = 2;
Shouldn't be necessary.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/StaticT...
File dart/tests/language/src/StaticTopLevelTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/StaticT...
dart/tests/language/src/StaticTopLevelTest.dart:5: static method() { }          
       /// 00: compile-time error
static is a pseudo keyword. So this is a type annotation that refers to a
missing type. That is not a compile-time error.

[ngeoffray, 2011-11-03 16:27:27]

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix13NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix13NegativeTest.dart:10: class MyClass extends
lib12.Library13 {
On 2011/11/03 16:16:45, ahe wrote:
> Is this change necessary?

No, I'm just making it compliant with our style.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix15NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix15NegativeTest.dart:10: class MyClass implements
lib12.Library13 {
On 2011/11/03 16:16:45, ahe wrote:
> Necessary?

Ditto.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix18NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix18NegativeTest.dart:11: lib1.invalid.foo();
On 2011/11/03 16:16:45, ahe wrote:
> Not sure this should be needed.

Ok, removed.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
File dart/tests/language/src/Prefix19NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Prefix1...
dart/tests/language/src/Prefix19NegativeTest.dart:8: #import("library1.dart",
prefix:"$lib1");
On 2011/11/03 16:16:45, ahe wrote:
> This sucks. If this is indeed an error, then see the previous file.

Change removed.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Script2...
File dart/tests/language/src/Script2NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/Script2...
dart/tests/language/src/Script2NegativeTest.dart:11: new A().a = 2;
On 2011/11/03 16:16:45, ahe wrote:
> Shouldn't be necessary.

Change removed.

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/StaticT...
File dart/tests/language/src/StaticTopLevelTest.dart (right):

http://codereview.chromium.org/8437091/diff/1/dart/tests/language/src/StaticT...
dart/tests/language/src/StaticTopLevelTest.dart:5: static method() { }          
       /// 00: compile-time error
On 2011/11/03 16:16:45, ahe wrote:
> static is a pseudo keyword. So this is a type annotation that refers to a
> missing type. That is not a compile-time error.

Change removed.

[ahe, 2011-11-03 16:35:51]

LGTM, and thanks for cleaning this up!

http://codereview.chromium.org/8437091/diff/2002/dart/tests/language/src/Pref...
File dart/tests/language/src/Prefix13NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/2002/dart/tests/language/src/Pref...
dart/tests/language/src/Prefix13NegativeTest.dart:10: class MyClass extends
lib12.Library13 {
Better keep the original name :-)

[ngeoffray, 2011-11-03 16:39:12]

http://codereview.chromium.org/8437091/diff/2002/dart/tests/language/src/Pref...
File dart/tests/language/src/Prefix13NegativeTest.dart (right):

http://codereview.chromium.org/8437091/diff/2002/dart/tests/language/src/Pref...
dart/tests/language/src/Prefix13NegativeTest.dart:10: class MyClass extends
lib12.Library13 {
On 2011/11/03 16:35:51, ahe wrote:
> Better keep the original name :-)

Done.