Issue 8437081: Frog changes (in experimental) to get frog integrated into the test infrastructure.

Issue 8437081: Frog changes (in experimental) to get frog integrated into the test infrastructure. (Closed)

Created:
9 years, 1 month ago by ngeoffray

Modified:
9 years, 1 month ago

Reviewers:
ahe, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, jimhug, Siggi Cherem (dart-lang)

Base URL:
http://dart.googlecode.com/svn/experimental/frog/

Visibility:
Public.

Description

Frog changes (in experimental) to get frog integrated into the test infrastructure. Committed: https://code.google.com/p/dart/source/detail?r=1141

Patch Set 4 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -355 lines)			Patch
M	README.txt	View	1 2 3	1 chunk	+1 line, -9 lines	0 comments	Download
M	dart-frog.gyp	View	1 2 3	2 chunks	+32 lines, -8 lines	0 comments	Download
M	frog.py	View	1 2 3	6 chunks	+31 lines, -12 lines	0 comments	Download
M	frogsh	View	1 2 3	7 chunks	+21 lines, -6 lines	0 comments	Download
M	options.dart	View	1 2 3	4 chunks	+17 lines, -5 lines	0 comments	Download
M	presubmit.py	View	1 2 3	1 chunk	+5 lines, -4 lines	0 comments	Download
M	scripts/bootstrap/frog_bootstrap_wrapper.py	View	1 2 3	1 chunk	+6 lines, -14 lines	0 comments	Download
M	scripts/bootstrap/frog_wrapper.py	View	1 2 3	1 chunk	+22 lines, -7 lines	0 comments	Download
A +	scripts/bootstrap/frogsh_bootstrap_wrapper.py	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	scripts/buildbot_annotated_steps.py	View	1 2 3	2 chunks	+13 lines, -36 lines	2 comments	Download
D	tests/frog/frog.status	View	1 2 3	1 chunk	+0 lines, -201 lines	0 comments	Download
D	tests/frog/testcfg.py	View	1 2 3	1 chunk	+0 lines, -45 lines	0 comments	Download
M	world.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/8437081/diff/2003/scripts/buildbot_annotated_steps.py File scripts/buildbot_annotated_steps.py (left): http://codereview.chromium.org/8437081/diff/2003/scripts/buildbot_annotated_steps.py#oldcode91 scripts/buildbot_annotated_steps.py:91: status = subprocess.call(['rm', old_binary]) just to make sure ...

9 years, 1 month ago (2011-11-03 15:58:18 UTC) #3

ngeoffray

9 years, 1 month ago (2011-11-03 16:12:55 UTC) #4

http://codereview.chromium.org/8437081/diff/2003/scripts/buildbot_annotated_s...
File scripts/buildbot_annotated_steps.py (left):

http://codereview.chromium.org/8437081/diff/2003/scripts/buildbot_annotated_s...
scripts/buildbot_annotated_steps.py:91: status = subprocess.call(['rm',
old_binary])
On 2011/11/03 15:58:18, sigmund wrote:
> just to make sure I follow - this is not needed because now we made the
> dependence explicitly in the .gyp file, correct?

Yes, that's correct :)

Expand Messages | Collapse Messages