Issue 8437064: Integrate frog tests into presubmit.sh

Issue 8437064: Integrate frog tests into presubmit.sh (Closed)

Created:
9 years, 1 month ago by zundel

Modified:
9 years, 1 month ago

Reviewers:
jimhug, Siggi Cherem (dart-lang), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Integrate frog tests into presubmit.sh Committed: https://code.google.com/p/dart/source/detail?r=1145

Patch Set 2 : Get rid of superfluous change #

Total comments: 1

Patch Set 3 : Feedback from Siggi #

Total comments: 4

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -13 lines)			Patch
	M	tests/language/language.status	View		3 chunks	+13 lines, -5 lines	0 comments	Download
	M	tools/presubmit.sh	View	1 2	3 chunks	+28 lines, -8 lines	4 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jimhug

This looks good to me, but I'm adding Siggi in as a reviewer as my ...

9 years, 1 month ago (2011-11-02 19:45:12 UTC) #2

Siggi Cherem (dart-lang)

Thanks for doing this Eric! http://codereview.chromium.org/8437064/diff/1001/tools/presubmit.sh File tools/presubmit.sh (right): http://codereview.chromium.org/8437064/diff/1001/tools/presubmit.sh#newcode96 tools/presubmit.sh:96: (cd frog/bin; ln -s ...

9 years, 1 month ago (2011-11-02 20:12:14 UTC) #3

zundel

Updated to capture the result from the frog run to print out at the end.

9 years, 1 month ago (2011-11-02 22:45:16 UTC) #4

Siggi Cherem (dart-lang)

lgtm thanks! http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh File tools/presubmit.sh (right): http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh#newcode136 tools/presubmit.sh:136: cd - I didn't know about 'cd ...

9 years, 1 month ago (2011-11-02 23:22:00 UTC) #5

ngeoffray

LGTM http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh File tools/presubmit.sh (right): http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh#newcode93 tools/presubmit.sh:93: # Create a symlink for the Dart VM ...

9 years, 1 month ago (2011-11-03 12:33:04 UTC) #6

zundel

9 years, 1 month ago (2011-11-03 13:21:35 UTC) #7

r1145

http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh
File tools/presubmit.sh (right):

http://codereview.chromium.org/8437064/diff/1003/tools/presubmit.sh#newcode93
tools/presubmit.sh:93: # Create a symlink for the Dart VM for frog
On 2011/11/03 12:33:05, ngeoffray wrote:
> Not needed anymore.

Done.

Expand Messages | Collapse Messages