Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 8437056: Implemented File create API. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implemented File create API. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -46 lines) Patch
M runtime/bin/builtin_in.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/bin/file.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M runtime/bin/file.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/bin/file_impl.dart View 4 chunks +26 lines, -2 lines 0 comments Download
M runtime/bin/file_linux.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/bin/file_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/file_win.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/FileTest.dart View 2 chunks +29 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-02 15:45:45 UTC) #1
Søren Gjesse
9 years, 1 month ago (2011-11-02 15:55:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698