Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 8432002: Fix hilighting of string interpolation and several operators. (Closed)

Created:
9 years, 1 month ago by alf
Modified:
9 years, 1 month ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix hilighting of string interpolation and several operators. Committed: https://code.google.com/p/dart/source/detail?r=1003

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M utils/vim/syntax/dart.vim View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
alf
9 years, 1 month ago (2011-10-31 16:16:49 UTC) #1
Anton Muhin
LGTM! http://codereview.chromium.org/8432002/diff/1/utils/vim/syntax/dart.vim File utils/vim/syntax/dart.vim (right): http://codereview.chromium.org/8432002/diff/1/utils/vim/syntax/dart.vim#newcode52 utils/vim/syntax/dart.vim:52: syn match dartInterpolation contained "\$\(\w\+\|{[^\}]\+}\)" not sure it's ...
9 years, 1 month ago (2011-10-31 17:51:31 UTC) #2
alf
9 years, 1 month ago (2011-11-01 12:09:55 UTC) #3
Obviously it won't handle 100% of cases, but it's indeed much better that the
previous implementation.

Powered by Google App Engine
This is Rietveld 408576698