Some Linux and Mac OS event handler refactoring

Some Linux and Mac OS event handler refactoring

This moved some of the handling of the data on a socket to a socket data object.

This is a step in preparation for another change where more state will be stored on socket data object.

This is also a step in moving from an array of socket data objects indexed by the file descriptor to a hash map of socket data objects.

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1001

[Søren Gjesse, 2011-11-01 08:40:52]

The Linux and Mac OS changes are identical.

[Mads Ager (google), 2011-11-01 09:10:23]

LGTM

Same comments apply to Mac.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux.cc
File runtime/bin/eventhandler_linux.cc (right):

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.cc:50: port_map_entries_ = 0;
Should we either keep the name PortData or call these socket_map_entries_, etc.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.cc:53: sizeof(SocketData)));
funky indentation.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux.h
File runtime/bin/eventhandler_linux.h (right):

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:26: 
Remove one newline?

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:59: SocketData* port_map_;
Should this be socket_map_ instead of port_map_?

[Søren Gjesse, 2011-11-01 11:34:21]

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux.cc
File runtime/bin/eventhandler_linux.cc (right):

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.cc:50: port_map_entries_ = 0;
On 2011/11/01 09:10:23, Mads Ager wrote:
> Should we either keep the name PortData or call these socket_map_entries_,
etc.

Done.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.cc:53: sizeof(SocketData)));
On 2011/11/01 09:10:23, Mads Ager wrote:
> funky indentation.

Done.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux.h
File runtime/bin/eventhandler_linux.h (right):

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:26: 
On 2011/11/01 09:10:23, Mads Ager wrote:
> Remove one newline?

Done.

http://codereview.chromium.org/8431027/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:59: SocketData* port_map_;
On 2011/11/01 09:10:23, Mads Ager wrote:
> Should this be socket_map_ instead of port_map_?

Done.