Constructor parameters should have this.<field> reference elements set.

Constructor parameters should have this.<field> reference elements set.


R=brianwilkerson@google.com,mmendez
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1043

[fabiomfv, 2011-11-01 14:08:56]

DBC

http://codereview.chromium.org/8431008/diff/4/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/8431008/diff/4/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1310:
DartPropertyAccess prop = (DartPropertyAccess)parameter.getName();
DBC - bear in mind that the parameter is not strictly the field. it is a field
in the scope of the constructor body, init list. we need to be sure this will
not have undesired side effect during object creation.

[codefu, 2011-11-01 18:00:20]

http://codereview.chromium.org/8431008/diff/4/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/8431008/diff/4/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1310:
DartPropertyAccess prop = (DartPropertyAccess)parameter.getName();
On 2011/11/01 14:08:56, fabiomfv wrote:
> DBC - bear in mind that the parameter is not strictly the field. it is a field
> in the scope of the constructor body, init list. we need to be sure this will
> not have undesired side effect during object creation. 

Double checked and everything looks good.  All presubmit tests pass.

[mmendez, 2011-11-01 19:13:15]

LGTM

It would be good to have a test for this behavior.

[Brian Wilkerson, 2011-11-01 19:22:11]

LGTM