Issue 8430037: Fix issue: 5427703 (compareTo), fix parsing of -0.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8430037: Fix issue: 5427703 (compareTo), fix parsing of -0.0. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix issue: 5427703 (compareTo), fix parsing of -0.0. Committed: https://code.google.com/p/dart/source/detail?r=1156

Patch Set 5 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -10 lines)			Patch
M	runtime/lib/double.dart	View	1 2 3	3 chunks	+27 lines, -4 lines	0 comments	Download
M	runtime/vm/ast.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	4 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm http://codereview.chromium.org/8430037/diff/3004/runtime/lib/double.dart File runtime/lib/double.dart (right): http://codereview.chromium.org/8430037/diff/3004/runtime/lib/double.dart#newcode219 runtime/lib/double.dart:219: return LESS; How do we get here? Which ...

9 years, 1 month ago (2011-11-03 17:20:40 UTC) #2

srdjan

9 years, 1 month ago (2011-11-03 17:50:39 UTC) #3

Also added fixes to co19 status (mark 3 tests as failed, enable two tests)

http://codereview.chromium.org/8430037/diff/3004/runtime/lib/double.dart
File runtime/lib/double.dart (right):

http://codereview.chromium.org/8430037/diff/3004/runtime/lib/double.dart#newc...
runtime/lib/double.dart:219: return LESS;
On 2011/11/03 17:20:40, hausner wrote:
> How do we get here? Which case is this? Seems like all cases are handled
> above...

When other is NaN. Added comment.

Expand Messages | Collapse Messages

Issue 8430037: Fix issue: 5427703 (compareTo), fix parsing of -0.0. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages