Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8430032: Skip tests that behaves differently in checked mode (Closed)

Created:
9 years, 1 month ago by ahe
Modified:
9 years, 1 month ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Skip tests that behaves differently in checked mode Committed: https://code.google.com/p/dart/source/detail?r=1017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M dart/tests/co19/co19-runtime.status View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
TBR
9 years, 1 month ago (2011-11-01 15:10:26 UTC) #1
kasperl
LGTM. Looking forward to getting this sorted out so we have a good way of ...
9 years, 1 month ago (2011-11-01 15:16:38 UTC) #2
Ivan Posva
9 years, 1 month ago (2011-11-01 15:19:06 UTC) #3
Please do not skip tests. Instead mark them as flaky if they have pass/fail
behaviour. Skipping tests should be the last resort, because by skipping tests
we do not even get crash reports.

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698