Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 8430007: Proper reg for deoptiomization. (Closed)

Created:
9 years, 1 month ago by Anton Muhin
Modified:
9 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Proper reg for deoptiomization. EAX may get overwritten by the operation. Original value can be restored from ECX. Committed: https://code.google.com/p/dart/source/detail?r=958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M runtime/vm/opt_code_generator_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/DeoptimizationTest.dart View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
9 years, 1 month ago (2011-10-31 17:37:46 UTC) #1
srdjan
9 years, 1 month ago (2011-10-31 17:45:56 UTC) #2
LGTM!
Thanks!

Powered by Google App Engine
This is Rietveld 408576698