Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Issue 8430005: Tell the testing-framework that we started the tests. (Closed)

Created:
9 years, 1 month ago by floitsch
Modified:
9 years, 1 month ago
Reviewers:
vsm, Anton Muhin, ngeoffray
CC:
reviews_dartlang.org, antonm
Visibility:
Public.

Description

Tell the testing-framework that we started the tests. Committed: https://code.google.com/p/dart/source/detail?r=956

Patch Set 1 #

Patch Set 2 : Workaround #

Patch Set 3 : Rename and other fixes. #

Total comments: 2

Patch Set 4 : Cosmetic change (comment).wq #

Patch Set 5 : Update status file. #

Patch Set 6 : Address comment. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M client/testing/unittest/test_controller.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M client/testing/unittest/unittest.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M tools/testing/architecture.py View 1 2 3 4 5 4 chunks +22 lines, -11 lines 3 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
I'm not 100% sure the nested timeout is necessary, but it can't hurt, and I ...
9 years, 1 month ago (2011-10-31 16:53:19 UTC) #1
ngeoffray
LGTM, but I can't really say about the nested timeout. Maybe Vijay or Anton will ...
9 years, 1 month ago (2011-10-31 16:55:54 UTC) #2
floitsch
http://codereview.chromium.org/8430005/diff/4/tools/testing/architecture.py File tools/testing/architecture.py (right): http://codereview.chromium.org/8430005/diff/4/tools/testing/architecture.py#newcode78 tools/testing/architecture.py:78: wait() { On 2011/10/31 16:55:54, ngeoffray wrote: > waitForDone? ...
9 years, 1 month ago (2011-10-31 16:59:48 UTC) #3
vsm
http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py File tools/testing/architecture.py (right): http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py#newcode42 tools/testing/architecture.py:42: <script type="%(script_type)s" src="%(source_script)s"></script> Note, we're changing Dart scripts to ...
9 years, 1 month ago (2011-10-31 17:48:21 UTC) #4
floitsch
http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py File tools/testing/architecture.py (right): http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py#newcode42 tools/testing/architecture.py:42: <script type="%(script_type)s" src="%(source_script)s"></script> On 2011/10/31 17:48:21, vsm wrote: > ...
9 years, 1 month ago (2011-10-31 18:00:36 UTC) #5
Anton Muhin
http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py File tools/testing/architecture.py (right): http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py#newcode51 tools/testing/architecture.py:51: // A window.postMessage might have been enqueued after this ...
9 years, 1 month ago (2011-10-31 18:19:24 UTC) #6
floitsch
9 years, 1 month ago (2011-10-31 18:48:45 UTC) #7
On 2011/10/31 18:19:24, antonmuhin wrote:
> http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.py
> File tools/testing/architecture.py (right):
> 
>
http://codereview.chromium.org/8430005/diff/4004/tools/testing/architecture.p...
> tools/testing/architecture.py:51: // A window.postMessage might have been
> enqueued after this timeout.
> I don't know all the details, but maybe trigger first callback on
> DOMContentLoaded?

http://codereview.chromium.org/8427012/

Powered by Google App Engine
This is Rietveld 408576698