Issue 8428006: Fix prefix variable parse errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8428006: Fix prefix variable parse errors (Closed)

Created:
9 years, 1 month ago by codefu

Modified:
9 years, 1 month ago

Reviewers:
mmendez, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix prefix variable parse errors R=floitsch@google.com,mmendez BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1010

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A	tests/language/src/Prefix17Test.dart	View	1 chunk	+19 lines, -0 lines	2 comments	Download
M	tests/language/src/library12.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmendez

LGTM http://codereview.chromium.org/8428006/diff/1/tests/language/src/Prefix17Test.dart File tests/language/src/Prefix17Test.dart (right): http://codereview.chromium.org/8428006/diff/1/tests/language/src/Prefix17Test.dart#newcode18 tests/language/src/Prefix17Test.dart:18: //print("${LocalClass.static_fld}, ${lc1.fld}, ${lc2.fld}, ${lc2m.fld}, ${lib12.Library12.static_fld}"); Did you want ...

9 years, 1 month ago (2011-11-01 14:02:08 UTC) #3

codefu

9 years, 1 month ago (2011-11-01 14:03:08 UTC) #4

http://codereview.chromium.org/8428006/diff/1/tests/language/src/Prefix17Test...
File tests/language/src/Prefix17Test.dart (right):

http://codereview.chromium.org/8428006/diff/1/tests/language/src/Prefix17Test...
tests/language/src/Prefix17Test.dart:18: //print("${LocalClass.static_fld},
${lc1.fld}, ${lc2.fld}, ${lc2m.fld}, ${lib12.Library12.static_fld}");
On 2011/11/01 14:02:08, mmendez wrote:
> Did you want to do an Expects here to check something behavior?
> 
> Also, we should double check that we properly resolve two classes with the
same
> name where one is imported via a prefix if we don't have such a test already.

I'll update with expect tests and also check the other tests for that coverage.

Expand Messages | Collapse Messages