Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8427012: Increase timeout and start only when document is loaded. (Closed)

Created:
9 years, 1 month ago by floitsch
Modified:
9 years, 1 month ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Increase timeout. Hopefully this reduces the flakiness on the build-server. Start timeout only when document is loaded. Committed: https://code.google.com/p/dart/source/detail?r=964

Patch Set 1 #

Patch Set 2 : Wait with timeout until document is loaded. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M tools/testing/architecture.py View 1 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
9 years, 1 month ago (2011-10-31 18:19:09 UTC) #1
Anton Muhin
LGTM
9 years, 1 month ago (2011-10-31 18:48:49 UTC) #2
vsm
9 years, 1 month ago (2011-10-31 19:33:32 UTC) #3
LGTM, but we should clean up at some point.

Powered by Google App Engine
This is Rietveld 408576698