Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 8412007: - Add a test for basic passing of arguments from the command line. (Closed)

Created:
9 years, 1 month ago by Ivan Posva
Modified:
9 years, 1 month ago
Reviewers:
dgrove, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Add a test for basic passing of arguments from the command line. Committed: https://code.google.com/p/dart/source/detail?r=1171

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A standalone/src/OptionsTest.dart View 1 1 chunk +30 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
9 years, 1 month ago (2011-11-03 21:42:11 UTC) #1
siva
lgtm
9 years, 1 month ago (2011-11-03 21:47:08 UTC) #2
Ivan Posva
Slightly expanded the test coverage. -Ivan
9 years, 1 month ago (2011-11-03 21:55:15 UTC) #3
siva
9 years, 1 month ago (2011-11-03 22:03:33 UTC) #4
Still LGTM

http://codereview.chromium.org/8412007/diff/4001/standalone/src/OptionsTest.dart
File standalone/src/OptionsTest.dart (right):

http://codereview.chromium.org/8412007/diff/4001/standalone/src/OptionsTest.d...
standalone/src/OptionsTest.dart:22: Expect.equals("Fourth", opts.arguments[3]);
You should also modify one of the existing arguments
e.g:
opts.arguments[1] = "NewOptionsTest";
Expect.equals("NewOptionsTest", opts.arguments[1]);

Powered by Google App Engine
This is Rietveld 408576698