Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 8404004: Don't throw assertion when dart:lib cannot be found. (Closed)

Created:
9 years, 1 month ago by codefu
Modified:
9 years, 1 month ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't throw assertion when dart:lib cannot be found. Missing LibrarySource gets reported as such. R=jwren@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/SystemLibraryManager.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
codefu
9 years, 1 month ago (2011-10-26 20:45:11 UTC) #1
jwren
9 years, 1 month ago (2011-10-26 21:12:44 UTC) #2
On 2011/10/26 20:45:11, codefu wrote:

lgtm

Powered by Google App Engine
This is Rietveld 408576698