Add support for 'Dynamic' type in the VM.

Add support for 'Dynamic' type in the VM.
Add a test and disable if for dartc.
Committed: https://code.google.com/p/dart/source/detail?r=862

[hausner, 2011-10-26 22:41:11]

I don't think this works. See comment below.

Also, you need to at least handle "Dynamic" in SkipType().

Would it be simpler to make Dynamic a predefined identifier instead of a
keyword?

http://codereview.chromium.org/8403005/diff/1/runtime/vm/token.h
File runtime/vm/token.h (right):

http://codereview.chromium.org/8403005/diff/1/runtime/vm/token.h#newcode148
runtime/vm/token.h:148: KW(kDYNAMIC, "Dynamic", 0, kKeyword)                    
                    \
I don't think this works. The list must be alphabetically sorted. The lookup
code is case sensitive, so Dynamic should be the very first keyword in the list.

[regis, 2011-10-27 01:29:14]

Thanks for the comments. You can still wait for the review, since it is not
working yet.

> Also, you need to at least handle "Dynamic" in SkipType().
Done.

> Would it be simpler to make Dynamic a predefined identifier instead of a
keyword?
No, I think that a keyword is simpler, because we would have to check that
identifier is not 'Dynamic' in as many places.

Thanks for now.

http://codereview.chromium.org/8403005/diff/1/runtime/vm/token.h
File runtime/vm/token.h (right):

http://codereview.chromium.org/8403005/diff/1/runtime/vm/token.h#newcode148
runtime/vm/token.h:148: KW(kDYNAMIC, "Dynamic", 0, kKeyword)                    
                    \
On 2011/10/26 22:41:11, hausner wrote:
> I don't think this works. The list must be alphabetically sorted. The lookup
> code is case sensitive, so Dynamic should be the very first keyword in the
list.

Indeed. I realized quickly after adding a test :-)

[regis, 2011-10-27 23:04:29]

Please, have another look.
This is a much simpler approach, literally a 2 line change.

I may still need to detect illegal uses of Dynamic as I add tests and negative
tests. But I'd like to submit this first.

Thanks,
Regis

[hausner, 2011-10-27 23:51:58]

LGTM. I like this approach better.