Issue 8403003: Rename the VM internal 'var' type to 'Dynamic' type.

Issue 8403003: Rename the VM internal 'var' type to 'Dynamic' type. (Closed)

Created:
9 years, 1 month ago by regis

Modified:
9 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Rename the VM internal 'var' type to 'Dynamic' type. This change does not implement support for the built-in identifier 'Dynamic'. Committed: https://code.google.com/p/dart/source/detail?r=779

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -115 lines)			Patch
M	runtime/lib/error.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/ast_printer_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/ast_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	9 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	25 chunks	+38 lines, -38 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	26 chunks	+31 lines, -29 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scopes_test.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/src/TypeVMTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/8403003/diff/1/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): http://codereview.chromium.org/8403003/diff/1/runtime/vm/code_generator_ia32.cc#newcode1483 runtime/vm/code_generator_ia32.cc:1483: // Any expression is assignable to the VarType. ...

9 years, 1 month ago (2011-10-26 20:43:03 UTC) #2

regis

9 years, 1 month ago (2011-10-26 20:58:03 UTC) #3

I had missed a few others. Thanks!

http://codereview.chromium.org/8403003/diff/1/runtime/vm/code_generator_ia32.cc
File runtime/vm/code_generator_ia32.cc (right):

http://codereview.chromium.org/8403003/diff/1/runtime/vm/code_generator_ia32....
runtime/vm/code_generator_ia32.cc:1483: // Any expression is assignable to the
VarType. Skip the test.
On 2011/10/26 20:43:03, srdjan wrote:
> VarType -> DynamicType

Done.

http://codereview.chromium.org/8403003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8403003/diff/1/runtime/vm/object.cc#newcode560
runtime/vm/object.cc:560: // The classes 'null', 'dynamic', and 'void' are not
registered in the class
On 2011/10/26 20:43:03, srdjan wrote:
> capital 'D' in 'Dynamic'.

Done.

http://codereview.chromium.org/8403003/diff/1/runtime/vm/object.cc#newcode1220
runtime/vm/object.cc:1220: // Any type is more specific than the VarType on the
righthand side.
On 2011/10/26 20:43:03, srdjan wrote:
> VarType-> DynamicType (3x above).

Done.

http://codereview.chromium.org/8403003/diff/1/runtime/vm/object.cc#newcode1296
runtime/vm/object.cc:1296: // class Object. An interface is also more specific
than the VarType.
On 2011/10/26 20:43:03, srdjan wrote:
> VarType -> DynamicType in comment

Done.

Expand Messages | Collapse Messages