Issue 8400058: Fix type error in tools/testing/dart/status_expression.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400058: Fix type error in tools/testing/dart/status_expression.dart. (Closed)

Created:
9 years, 1 month ago by William Hesse

Modified:
9 years, 1 month ago

Reviewers:
Mads Ager (google), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix type error in tools/testing/dart/status_expression.dart. BUG= TEST=standalone/StatusExpressionTest Committed: https://code.google.com/p/dart/source/detail?r=887

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/standalone/standalone.status	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	tools/testing/dart/status_expression.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

9 years, 1 month ago (2011-10-28 11:45:48 UTC) #3

LGTM

http://codereview.chromium.org/8400058/diff/1/tests/standalone/standalone.status
File tests/standalone/standalone.status (right):

http://codereview.chromium.org/8400058/diff/1/tests/standalone/standalone.sta...
tests/standalone/standalone.status:60: StatusExpressionTest: Skip # Uses
tools/testing library.
We should investigate this. I don't think we need to disable this one. The
language/src/Cyclic* test includes in the same way and runs fine.

Expand Messages | Collapse Messages