Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 8399016: - Add new test for regex (Closed)

Created:
9 years, 1 month ago by siva
Modified:
9 years, 1 month ago
Reviewers:
turnidge, regis, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Add new test for regex - Update test status Committed: https://code.google.com/p/dart/source/detail?r=902

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M co19/co19-runtime.status View 1 2 chunks +9 lines, -1 line 0 comments Download
A corelib/src/RegExp4Test.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A corelib/src/RegExp5Test.dart View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
9 years, 1 month ago (2011-10-26 23:43:36 UTC) #1
regis
LGTM
9 years, 1 month ago (2011-10-26 23:57:20 UTC) #2
ngeoffray
DBC Thanks very much Siva for the test case! http://codereview.chromium.org/8399016/diff/1/language/src/RegExp4Test.dart File language/src/RegExp4Test.dart (right): http://codereview.chromium.org/8399016/diff/1/language/src/RegExp4Test.dart#newcode1 language/src/RegExp4Test.dart:1: ...
9 years, 1 month ago (2011-10-27 09:24:45 UTC) #3
siva
9 years, 1 month ago (2011-10-27 21:58:10 UTC) #4
http://codereview.chromium.org/8399016/diff/1/language/src/RegExp4Test.dart
File language/src/RegExp4Test.dart (right):

http://codereview.chromium.org/8399016/diff/1/language/src/RegExp4Test.dart#n...
language/src/RegExp4Test.dart:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
On 2011/10/27 09:24:45, ngeoffray wrote:
> Could you put this test into corelib instead? Thanks!

Done.

Powered by Google App Engine
This is Rietveld 408576698