Issue 8394065: Fixes to allow natives in copy_dart.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8394065: Fixes to allow natives in copy_dart.py. (Closed)

Created:
9 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
9 years, 1 month ago

Reviewers:
vsm, jimhug, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fixes to allow natives in copy_dart.py. Committed: https://code.google.com/p/dart/source/detail?r=774

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -21 lines)			Patch
	M	client/tools/copy_dart.py	View		4 chunks	+43 lines, -21 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

my idea is to eventually use copy_dart to build tip...

9 years, 1 month ago (2011-10-26 18:53:50 UTC) #1

vsm

LGTM http://codereview.chromium.org/8394065/diff/1/client/tools/copy_dart.py File client/tools/copy_dart.py (right): http://codereview.chromium.org/8394065/diff/1/client/tools/copy_dart.py#newcode16 client/tools/copy_dart.py:16: r'^#(library|import|source|native|resource)$[\'"]([^\'"]*)[\'"](.*)$;$') Is "resource" standard?

9 years, 1 month ago (2011-10-26 19:52:28 UTC) #2

Siggi Cherem (dart-lang)

http://codereview.chromium.org/8394065/diff/1/client/tools/copy_dart.py File client/tools/copy_dart.py (right): http://codereview.chromium.org/8394065/diff/1/client/tools/copy_dart.py#newcode16 client/tools/copy_dart.py:16: r'^#(library|import|source|native|resource)$[\'"]([^\'"]*)[\'"](.*)$;$') On 2011/10/26 19:52:29, vsm wrote: > Is "resource" ...

9 years, 1 month ago (2011-10-26 20:03:11 UTC) #3

jimhug

9 years, 1 month ago (2011-10-26 23:43:22 UTC) #4

LGTM

However, this file really needs to get moved to dart ASAP so that it can use the
lang.dart existing support for crawling dart libraries rather than attempting to
recreate it in Python.

Expand Messages | Collapse Messages