Issue 8394057: Fix issue 235.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8394057: Fix issue 235. (Closed)

Created:
9 years, 1 month ago by regis

Modified:
9 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix issue 235. Add test. Disable new test for dartc. Committed: https://code.google.com/p/dart/source/detail?r=766

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
M	runtime/vm/object.cc	View	1 2 3	2 chunks	+13 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/8394057/diff/6001/tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart File tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart (right): http://codereview.chromium.org/8394057/diff/6001/tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart#newcode5 tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart:5: Map<String> foo; Add a comment why this is ...

9 years, 1 month ago (2011-10-26 17:46:25 UTC) #2

regis

9 years, 1 month ago (2011-10-26 17:59:37 UTC) #3

Thanks!

http://codereview.chromium.org/8394057/diff/6001/tests/language/src/WrongNumb...
File tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart (right):

http://codereview.chromium.org/8394057/diff/6001/tests/language/src/WrongNumb...
tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart:5: Map<String> foo;
On 2011/10/26 17:46:25, srdjan wrote:
> Add a comment why this is failing

Done.

Expand Messages | Collapse Messages

Issue 8394057: Fix issue 235. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages