Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 8394041: Implement path canonicalization on Windows to fix infinite loop on cyclic includes. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement path canonicalization on Windows to fix infinite loop on cyclic includes. R=sgjesse@google.com BUG=179 TEST=language/CyclicImportTest Committed: https://code.google.com/p/dart/source/detail?r=744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M runtime/bin/file_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-10-26 11:43:08 UTC) #1
Søren Gjesse
9 years, 1 month ago (2011-10-26 12:39:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698