Report an error if a constructor initializer calls a setter method.

Report an error if a constructor initializer calls a setter method.

BUG=http://code.google.com/p/dart/issues/detail?id=92

Committed: https://code.google.com/p/dart/source/detail?r=760

[fabiomfv, 2011-10-26 14:08:17]

LGTM! minor comment.

http://codereview.chromium.org/8394018/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/8394018/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1060: // HACK -
rely on the fact that accessors cannot shadow a field
not sure why deserves the comment as a 'hack'. dart spec states in (section 3.1)
- though incomplete and somewhat vague, that it should be a compile error.

[mmendez, 2011-10-26 17:14:58]

http://codereview.chromium.org/8394018/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/8394018/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1060: // HACK -
rely on the fact that accessors cannot shadow a field
I'll update the comment.  I should have been clearer that this is not about the
spec.  Basically, we create field elements for both properties and fields. 
Everything works out okay because if there a was a collision between a property
and a field we'd never get here.

On 2011/10/26 14:08:17, fabiomfv wrote:
> not sure why deserves the comment as a 'hack'. dart spec states in (section
3.1)
> - though incomplete and somewhat vague, that it should be a compile error.