Issue 8394006: Import with keyword for 2.5 python as well as backport os.path.relpath() from python unittest2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8394006: Import with keyword for 2.5 python as well as backport os.path.relpath() from python unittest2 (Closed)

Created:
9 years, 2 months ago by codefu

Modified:
9 years, 2 months ago

Reviewers:
mmendez

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Import with keyword for 2.5 python as well as backport os.path.relpath() from python unittest2 R=mmendez BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=708

Patch Set 1 #

Patch Set 2 : Backing out tools change #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	compiler/generate_source_list.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	compiler/generate_systemlibrary_list.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmendez

On 2011/10/25 18:24:43, codefu wrote: Like we discussed over IM, lets address the compiler issues ...

9 years, 2 months ago (2011-10-25 18:30:18 UTC) #2

codefu

On 2011/10/25 18:30:18, mmendez wrote: > On 2011/10/25 18:24:43, codefu wrote: > > Like we ...

9 years, 2 months ago (2011-10-25 18:31:15 UTC) #3

mmendez

9 years, 2 months ago (2011-10-25 18:41:21 UTC) #4

LGTM - Please double check that python 2.6 doesn't emit any warnings as a
result.

On 2011/10/25 18:31:15, codefu wrote:
> On 2011/10/25 18:30:18, mmendez wrote:
> > On 2011/10/25 18:24:43, codefu wrote:
> > 
> > Like we discussed over IM, lets address the compiler issues in one change. 
> The
> > os.path.relpath is a separate matter.
> 
> patch 2 removed the relpath issue.

Expand Messages | Collapse Messages