Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 8393033: Fix type tests involving an implicit closure of a non-parameterized class (Closed)

Created:
9 years, 2 months ago by regis
Modified:
9 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type tests involving an implicit closure of a non-parameterized class extending a parameterized class. Add corresponding test. Disable new test for dartc (filed new issue 5516001). Committed: https://code.google.com/p/dart/source/detail?r=771

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -29 lines) Patch
M runtime/vm/code_generator.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/code_generator_ia32.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 2 3 6 chunks +35 lines, -20 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 2 chunks +9 lines, -8 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/MethodOverrideTest.dart View 1 2 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
9 years, 2 months ago (2011-10-26 00:30:55 UTC) #1
siva
9 years, 1 month ago (2011-10-26 18:51:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698