Move JSON unit tests to new test API.

Move JSON unit tests to new test API.

Committed: https://code.google.com/p/dart/source/detail?r=905

[Bob Nystrom, 2011-10-26 00:14:23]

In addition to moving it to use the new test API, this also deletes a bunch of
old unused (I think?) stuff in there. As far as I can tell some of that wouldn't
even work right now.

If that's not cruft, let me know how to test it and I'll bring it back and fix
it.

[Siggi Cherem (dart-lang), 2011-10-26 00:16:40]

lgtm

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
File client/tests/client/json/json_tests.dart (right):

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:100: validateRoundTrip({'x':3,
'y':-4.5, 'z':'hi', 'w':null, 'u':true, 'v':false});
80 col

[Anton Muhin, 2011-10-26 13:21:00]

LGTM, but

1) all this stuff was needed to be able to run tests standalone (with DartVM)
and in browser.  I hope we either have it right now, or will have it soon,
correct?

2) just for a paranoid me, in DartC mode, do we run against JS backed
implementation, may you double check it?

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
File client/tests/client/json/json_tests.dart (right):

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:140: expectValueEquals(expected,
actual, [String message='']) {
nit: spaces around =

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:158: [String message='', bool
checkValues=true]) {
nit: ditto.

[Bob Nystrom, 2011-10-27 21:05:26]

On 2011/10/26 13:21:00, antonmuhin wrote:
> LGTM, but
> 
> 1) all this stuff was needed to be able to run tests standalone (with DartVM)
> and in browser.

I know it was needed for that, but I couldn't figure out how that code in there
ever worked in its current form. cmd_json_test.dart isn't even importing the
actual tests. I don't know why web_json_test.dart is even needed since the main
json_tests.dart implicity runs in a browser.

I talked to Siggy (I think?) about this briefly and I couldn't even figure out
if that code was being used. If it is still used somehow, I'd like to know how
to invoke it. :)

Otherwise, I'll just consider it dead and then work to re-enable running these
from the VM later with the new unittestsuite API.

>  I hope we either have it right now, or will have it soon, correct?

I hope to have it soon. My plan is:

1. Get all of the existing tests to use the new API (what I'm doing now).
2. Remove the old UnitTestSuite API.
3. Add support for command-line use of unittestlib.

I'm almost done with step 1. I have a CL that does most of step 2. Step 3
shouldn't be hard.

> 
> 2) just for a paranoid me, in DartC mode, do we run against JS backed
> implementation, may you double check it?

Sure, do you know how I can validate that?

> 
>
http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
> File client/tests/client/json/json_tests.dart (right):
> 
>
http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
> client/tests/client/json/json_tests.dart:140: expectValueEquals(expected,
> actual, [String message='']) {
> nit: spaces around =
> 
>
http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
> client/tests/client/json/json_tests.dart:158: [String message='', bool
> checkValues=true]) {
> nit: ditto.

[Bob Nystrom, 2011-10-27 21:06:14]

Not checking in just yet in case there's anything else Anton wants me to do...

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
File client/tests/client/json/json_tests.dart (right):

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:100: validateRoundTrip({'x':3,
'y':-4.5, 'z':'hi', 'w':null, 'u':true, 'v':false});
On 2011/10/26 00:16:40, sigmund wrote:
> 80 col

Done.

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:140: expectValueEquals(expected,
actual, [String message='']) {
On 2011/10/26 13:21:00, antonmuhin wrote:
> nit: spaces around = 

Done.

http://codereview.chromium.org/8392022/diff/1/client/tests/client/json/json_t...
client/tests/client/json/json_tests.dart:158: [String message='', bool
checkValues=true]) {
On 2011/10/26 13:21:00, antonmuhin wrote:
> nit: ditto.

Done.