Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 8391009: Reroll r634 "Total now reads mortgage sample from server" (Closed)

Created:
9 years, 1 month ago by rchandia
Modified:
9 years, 1 month ago
Reviewers:
Dan Rice
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reroll r634 "Total now reads mortgage sample from server" Fixed client/samples/total tests Fixes rename of Process.std{out,err} Original description: Removed example SYLK from client To get as SYLK spreadsheet named 'foo' http://localhost:9090/spreadsheet/get?name=foo To get a list of available spreasheets as a JSON array of Strings http://localhost:9090/spreadsheet/list For now the options are: - empty - mortgage - collatz - insertTest BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=831

Patch Set 1 #

Total comments: 10

Patch Set 2 : Removed blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -177 lines) Patch
M client/samples/total/src/Reader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/samples/total/src/SYLKReader.dart View 2 chunks +32 lines, -161 lines 0 comments Download
M client/samples/total/src/Total.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M client/tests/client/samples/total/total_tests.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M samples/total/src/Dartc.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A samples/total/src/GetSpreadsheet.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A samples/total/src/SYLKProducer.dart View 1 1 chunk +191 lines, -0 lines 0 comments Download
M samples/total/src/TotalRunner.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M samples/total/src/TotalServer.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dan Rice
LGTM http://codereview.chromium.org/8391009/diff/1/samples/total/src/Dartc.dart File samples/total/src/Dartc.dart (right): http://codereview.chromium.org/8391009/diff/1/samples/total/src/Dartc.dart#newcode61 samples/total/src/Dartc.dart:61: _readAll(false, compiler.stdout, new List<int>(BUFSIZE), messages); should this be ...
9 years, 1 month ago (2011-10-25 21:33:16 UTC) #1
rchandia
http://codereview.chromium.org/8391009/diff/1/samples/total/src/Dartc.dart File samples/total/src/Dartc.dart (right): http://codereview.chromium.org/8391009/diff/1/samples/total/src/Dartc.dart#newcode61 samples/total/src/Dartc.dart:61: _readAll(false, compiler.stdout, new List<int>(BUFSIZE), messages); On 2011/10/25 21:33:17, Dan ...
9 years, 1 month ago (2011-10-27 14:46:48 UTC) #2
Dan Rice
9 years, 1 month ago (2011-10-27 15:19:12 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698