Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 8391007: Complete generic closure type checking. (Closed)

Created:
9 years, 2 months ago by regis
Modified:
9 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Complete generic closure type checking. Disable a bad test in co19 (issue 5512850). Replace workaround by permanent fix for issue 5474672. Committed: https://code.google.com/p/dart/source/detail?r=713

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -50 lines) Patch
M runtime/vm/class_finalizer.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 chunks +18 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 9 chunks +60 lines, -44 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
9 years, 2 months ago (2011-10-25 17:43:40 UTC) #1
srdjan
9 years, 2 months ago (2011-10-25 20:05:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698