Issue 8390039: Missing parens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8390039: Missing parens (Closed)

Created:
9 years, 2 months ago by vsm

Modified:
9 years, 1 month ago

Reviewers:
jimhug, Jennifer Messerly, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Missing parens Frog is breaking on this when compiling swarm. Committed: https://code.google.com/p/dart/source/detail?r=750

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	client/html/release/html.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	client/html/src/DocumentFragmentWrappingImplementation.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jennifer Messerly

9 years, 1 month ago (2011-10-26 17:06:24 UTC) #3

On 2011/10/26 13:12:29, jimhug wrote:
> lgtm

lgtm too. The break was a type check warning, I hope?