Issue 8387017: Allow running frog tests on bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8387017: Allow running frog tests on bot (Closed)

Created:
9 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
9 years, 2 months ago

Reviewers:
jimhug, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Allow running frog tests on bot Committed: https://code.google.com/p/dart/source/detail?r=674

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	client/tools/buildbot_annotated_steps.py	View	1	3 chunks	+17 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jimhug

9 years, 2 months ago (2011-10-25 16:24:16 UTC) #3

lgtm

http://codereview.chromium.org/8387017/diff/2001/client/tools/buildbot_annota...
File client/tools/buildbot_annotated_steps.py (right):

http://codereview.chromium.org/8387017/diff/2001/client/tools/buildbot_annota...
client/tools/buildbot_annotated_steps.py:180: def ProcessFrog(srcpath):
I have minor fears for the frog here ... <smile>

Expand Messages | Collapse Messages