Issue 8386065: Fix problem with named arguments in constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8386065: Fix problem with named arguments in constructors (Closed)

Created:
9 years, 1 month ago by hausner

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix problem with named arguments in constructors When generating the implicit super call to the body, the argument names have to be duplicated from the implicit initializer call. Committed: https://code.google.com/p/dart/source/detail?r=1130

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

9 years, 1 month ago (2011-11-03 00:38:27 UTC) #3

Thanks. We do have a test for this. It's language/Constructor5Test. That's how I
found the bug. The test still fails, but for a different, unrelated reason.

Expand Messages | Collapse Messages