Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 8384005: New location for dartc_*.sh is Release_ia32 now that --mode is removed from (Closed)

Created:
9 years, 1 month ago by codefu
Modified:
9 years, 1 month ago
Reviewers:
mmendez, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New location for dartc_*.sh is Release_ia32 now that --mode is removed from build.py R=mmendez,ngeoffray BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M compiler/scripts/build_dartc_for_perf_metrics View 1 chunk +1 line, -1 line 0 comments Download
M compiler/scripts/compiler_compare.sh View 2 chunks +4 lines, -4 lines 0 comments Download
M compiler/scripts/compiler_series_test.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
codefu
9 years, 1 month ago (2011-10-31 15:18:36 UTC) #1
ngeoffray
9 years, 1 month ago (2011-10-31 15:39:22 UTC) #2
LGTM!

Sorry I did not notice those. I was only looking at how build.py is invoked.
It's scary to see that much non-portable scripts :)

Powered by Google App Engine
This is Rietveld 408576698