Issue 8383034: Rename various Proxy classes. Provide a Proxy interface.

Issue 8383034: Rename various Proxy classes. Provide a Proxy interface. (Closed)

Created:
9 years, 2 months ago by Ben Laurie (Google)

Modified:
9 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Rename various Proxy classes. Provide a Proxy interface. Committed: https://code.google.com/p/dart/source/detail?r=684

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -17 lines)			Patch
M	compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	corelib/src/implementation/promise_implementation.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	corelib/src/promise.dart	View	3 chunks	+20 lines, -6 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/stub-generator/testcfg.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. http://codereview.chromium.org/8383034/diff/1/compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java File compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java (right): http://codereview.chromium.org/8383034/diff/1/compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java#newcode274 compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java:274: // p("interface " + name + "$Proxy extends ...

9 years, 2 months ago (2011-10-25 10:55:42 UTC) #2

Ben Laurie (Google)

9 years, 2 months ago (2011-10-25 11:08:58 UTC) #3

On 2011/10/25 10:55:42, kasperl wrote:
> LGTM.
> 
>
http://codereview.chromium.org/8383034/diff/1/compiler/java/com/google/dart/c...
> File
>
compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java
> (right):
> 
>
http://codereview.chromium.org/8383034/diff/1/compiler/java/com/google/dart/c...
>
compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java:274:
> //    p("interface " + name + "$Proxy extends Proxy {");
> Intentional? Is this code supposed to be in or out?

Coming soon, I will omit it from the commit.

Expand Messages | Collapse Messages