Issue 8382017: Add Dart_GetNativeArgumentCount() and a test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8382017: Add Dart_GetNativeArgumentCount() and a test. (Closed)

Created:
9 years, 2 months ago by turnidge

Modified:
9 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, mattsh

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Add Dart_GetNativeArgumentCount() and a test. Committed: https://code.google.com/p/dart/source/detail?r=667

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -0 lines)			Patch
M	runtime/include/dart_api.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM http://codereview.chromium.org/8382017/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/8382017/diff/1/runtime/vm/dart_api_impl_test.cc#newcode1317 runtime/vm/dart_api_impl_test.cc:1317: " int method1(int i, int j) native \"Name_Does_Not_Matter\";" ...

9 years, 2 months ago (2011-10-24 22:58:43 UTC) #2

turnidge

9 years, 2 months ago (2011-10-24 23:44:19 UTC) #3

http://codereview.chromium.org/8382017/diff/1/runtime/vm/dart_api_impl_test.cc
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8382017/diff/1/runtime/vm/dart_api_impl_test.c...
runtime/vm/dart_api_impl_test.cc:1317: "  int method1(int i, int j) native
\"Name_Does_Not_Matter\";"
On 2011/10/24 22:58:43, asiva wrote:
> The new style now seems to be use '
> e.g: 'Name_Does_Not_Matter'

Done.

http://codereview.chromium.org/8382017/diff/1/runtime/vm/dart_api_impl_test.c...
runtime/vm/dart_api_impl_test.cc:1324: "}\n";
On 2011/10/24 22:58:43, asiva wrote:
> I believe in some of the newer tests we also removed the \n
> character to make it easier to read.
> 
> I will do a pass later over all the tests in this file to
> make the style consistent.

Done.

Expand Messages | Collapse Messages

Issue 8382017: Add Dart_GetNativeArgumentCount() and a test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages