Can not find Element in Dynamic element.

Can not find Element in Dynamic element.


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=650

[zundel, 2011-10-24 15:07:43]

http://codereview.chromium.org/8382003/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/8382003/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Elements.java:114: if (cls
instanceof ClassElementImplementation) {
I think rather than an instanceof test, the preferred way to handle this is to
find ElementKind.of(cls).  You'll want to test for ElementKind.CLASS.  I think
possibly a FUNCION_ALIAS might be passed in sometimes which you would want to
filter out.

http://codereview.chromium.org/8382003/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/8382003/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:547:
resolve(makeCode(
Won't resolveAndTest in conjuction with Joiner.on() work here?

I would like to refactor all these tests eventually, but I think the 'test' step
with some expected errors is what we want here.

[scheglov, 2011-10-24 19:57:55]

http://codereview.chromium.org/8382003/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/8382003/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Elements.java:114: if (cls
instanceof ClassElementImplementation) {
I'm not sure.
At first, we cast to this type, so it is just logical to test using instanceof.
At second, we would need to test not only for CLASS, but also for
FUNCTION_TYPE_ALIAS.

http://codereview.chromium.org/8382003/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/8382003/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:547:
resolve(makeCode(
On 2011/10/24 15:07:44, zundel wrote:
> Won't resolveAndTest in conjuction with Joiner.on() work here?
> 
> I would like to refactor all these tests eventually, but I think the 'test'
step
> with some expected errors is what we want here.

Done.

[zundel, 2011-10-24 20:01:02]

lgtm