Make DartVM build with clang.

Make DartVM build with clang.
Committed: https://code.google.com/p/dart/source/detail?r=966

[Anton Muhin, 2011-10-27 15:38:03]

PTAL.

Changes to globals.h are not needed anymore.

I don't know, maybe fixed by some other stuff, maybe by new version of clang.

[Ivan Posva, 2011-10-31 14:00:09]

LGTM -ip

http://codereview.chromium.org/8381037/diff/6002/runtime/third_party/jscre/pc...
File runtime/third_party/jscre/pcre_exec.cpp (right):

http://codereview.chromium.org/8381037/diff/6002/runtime/third_party/jscre/pc...
runtime/third_party/jscre/pcre_exec.cpp:1155: othercase = md.ignoreCase ?
kjs_pcre_ucp_othercase(stack.currentFrame->locals.fc) : -1;
Not sure what you changed here. And why it makes clang happier this way.

[Anton Muhin, 2011-10-31 18:46:01]

Thanks a lot for review, Ivan.

Rerunning builds once again and submitting unless someone speaks up against.

http://codereview.chromium.org/8381037/diff/6002/runtime/third_party/jscre/pc...
File runtime/third_party/jscre/pcre_exec.cpp (right):

http://codereview.chromium.org/8381037/diff/6002/runtime/third_party/jscre/pc...
runtime/third_party/jscre/pcre_exec.cpp:1155: othercase = md.ignoreCase ?
kjs_pcre_ucp_othercase(stack.currentFrame->locals.fc) : -1;
On 2011/10/31 14:00:09, Ivan Posva wrote:
> Not sure what you changed here. And why it makes clang happier this way.

Clang complains:

<quotation>
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:1017:25:
error: indirect goto might cross protected scopes
                        RRETURN_NO_MATCH;
                        ^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:274:48:
note: expanded from:
#define RRETURN_NO_MATCH do { isMatch = false; RRETURN; } while (0)
                                               ^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:272:17:
note: expanded from:
#define RRETURN goto RRETURN_LABEL
                ^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:1168:29:
note: possible target of indirect goto
                            RECURSIVE_MATCH(28,
stack.currentFrame->args.instructionPtr, stack.currentFrame->args.bracketChain);
                            ^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:262:9:
note: expanded from:
        RECURSIVE_MATCH_COMMON(num) \
        ^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:256:13:
note: expanded from:
    RRETURN_##num: \
            ^
<scratch space>:159:1: note: expanded from:
RRETURN_28
^
/Users/antonm/Google/dartium/src/dart/runtime/third_party/jscre/pcre_exec.cpp:1154:25:
note: jump bypasses variable initialization
                    int othercase = md.ignoreCase ?
kjs_pcre_ucp_othercase(stack.currentFrame->locals.fc) : -1;
</quotation>

I suspect it's 6.7/3:

<quotation>
3 It is possible to transfer into a block, but not in a way that bypasses
declarations with initialization. A program that jumps
77)
from a point where a local variable with automatic storage duration is not in
scope to a
point where it is in scope is ill-formed unless the variable has POD type (3.9)
and is declared without an
initializer (8.5)
</quotation>