Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8381036: Add a test for non-parameterized factory. (Closed)

Created:
9 years, 2 months ago by ngeoffray
Modified:
9 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a test for non-parameterized factory. Committed: https://code.google.com/p/dart/source/detail?r=697

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M tests/language/language.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/src/InterfaceFactoryMultiTest.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
A tests/language/src/NonParameterizedFactory2Test.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A tests/language/src/NonParameterizedFactoryTest.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
9 years, 2 months ago (2011-10-25 12:24:32 UTC) #1
ahe
LGTM! http://codereview.chromium.org/8381036/diff/1/tests/language/src/NonParameterizedFactoryTest.dart File tests/language/src/NonParameterizedFactoryTest.dart (right): http://codereview.chromium.org/8381036/diff/1/tests/language/src/NonParameterizedFactoryTest.dart#newcode11 tests/language/src/NonParameterizedFactoryTest.dart:11: factory Interface() { Interface<T> http://codereview.chromium.org/8381036/diff/1/tests/language/src/NonParameterizedFactoryTest.dart#newcode15 tests/language/src/NonParameterizedFactoryTest.dart:15: factory Interface.withArg(value) ...
9 years, 2 months ago (2011-10-25 13:19:11 UTC) #2
ngeoffray
Thanks, and PTAL http://codereview.chromium.org/8381036/diff/1/tests/language/src/NonParameterizedFactoryTest.dart File tests/language/src/NonParameterizedFactoryTest.dart (right): http://codereview.chromium.org/8381036/diff/1/tests/language/src/NonParameterizedFactoryTest.dart#newcode11 tests/language/src/NonParameterizedFactoryTest.dart:11: factory Interface() { On 2011/10/25 13:19:11, ...
9 years, 2 months ago (2011-10-25 13:33:08 UTC) #3
ahe
9 years, 2 months ago (2011-10-25 13:50:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698