Issue 8381018: Expect '{' during class parsing, report error if not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8381018: Expect '{' during class parsing, report error if not. (Closed)

Created:
9 years, 2 months ago by scheglov

Modified:
9 years, 2 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Expect '{' during class parsing, report error if not. R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=649

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -6 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	2 chunks	+33 lines, -0 lines	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserTests.java	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

9 years, 2 months ago (2011-10-24 19:32:04 UTC) #2

lgtm

http://codereview.chromium.org/8381018/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java
(right):

http://codereview.chromium.org/8381018/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:52:
"// filler filler filler filler filler",
I don't think we need this line.

http://codereview.chromium.org/8381018/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:61:
// there was NPE during this operation
The NPE is fixed now, let's remove the comment

Expand Messages | Collapse Messages