Issue 8380023: Implicitly move super constructor call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8380023: Implicitly move super constructor call (Closed)

Created:
9 years, 2 months ago by hausner

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Implicitly move super constructor call Implicitly move super constructor call to the end of the initializer list. Some code failed after r412. Committed: https://code.google.com/p/dart/source/detail?r=663

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -16 lines)			Patch
	M	runtime/vm/parser.cc	View	1	2 chunks	+14 lines, -13 lines	0 comments	Download
	M	tests/language/language.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

9 years, 2 months ago (2011-10-24 22:39:19 UTC) #2

LGTM

http://codereview.chromium.org/8380023/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8380023/diff/1/runtime/vm/parser.cc#newcode1396
runtime/vm/parser.cc:1396: // TODO(hausner): Move explicit supercall to the end
of the initializer
Is this TODO still needed?

Expand Messages | Collapse Messages