Issue 8380003: Switch to new test framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8380003: Switch to new test framework. (Closed)

Created:
9 years, 2 months ago by Ben Laurie (Google)

Modified:
9 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Switch to new test framework. TBR=kasperl Committed: https://code.google.com/p/dart/source/detail?r=629

Patch Set 3 : '' #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -202 lines)			Patch
M	tests/isolate/src/TestFramework.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest.dart	View	1	2 chunks	+24 lines, -51 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart	View	1	5 chunks	+33 lines, -60 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest.dart	View	1 2	2 chunks	+14 lines, -38 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart	View	1 2	4 chunks	+22 lines, -46 lines	0 comments	Download
M	tests/stub-generator/testcfg.py	View		2 chunks	+26 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. http://codereview.chromium.org/8380003/diff/4001/tests/stub-generator/testcfg.py File tests/stub-generator/testcfg.py (right): http://codereview.chromium.org/8380003/diff/4001/tests/stub-generator/testcfg.py#newcode70 tests/stub-generator/testcfg.py:70: if not (re.match('^\s+$', line) or line.startswith('//') or line.startswith('#')): ...

9 years, 2 months ago (2011-10-24 13:47:01 UTC) #2

Ben Laurie (Google)

9 years, 2 months ago (2011-10-24 14:21:42 UTC) #3

http://codereview.chromium.org/8380003/diff/4001/tests/stub-generator/testcfg.py
File tests/stub-generator/testcfg.py (right):

http://codereview.chromium.org/8380003/diff/4001/tests/stub-generator/testcfg...
tests/stub-generator/testcfg.py:70: if not (re.match('^\s+$', line) or
line.startswith('//') or line.startswith('#')):
On 2011/10/24 13:47:01, kasperl wrote:
> Long line.

Will be fixed in next commit.

Expand Messages | Collapse Messages

Issue 8380003: Switch to new test framework. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages