Issue 8379013: Implement new inline cache.

Issue 8379013: Implement new inline cache. (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

Implement new inline cache. Delete a lot of unused code (most of change). Committed: https://code.google.com/p/dart/source/detail?r=706

Patch Set 8 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -1349 lines)			Patch
M	vm/code_generator.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	vm/code_generator.cc	View	1 2 3 4 5 6 7	6 chunks	+45 lines, -117 lines	0 comments	Download
M	vm/code_generator_ia32.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -1 line	0 comments	Download
M	vm/code_patcher.h	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	vm/code_patcher_arm.cc	View	1 2	1 chunk	+8 lines, -11 lines	0 comments	Download
M	vm/code_patcher_ia32.cc	View	1	3 chunks	+1 line, -31 lines	0 comments	Download
M	vm/code_patcher_ia32_test.cc	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -35 lines	0 comments	Download
M	vm/code_patcher_x64.cc	View	1 2	1 chunk	+8 lines, -11 lines	0 comments	Download
M	vm/compiler.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	vm/ic_data.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
D	vm/ic_stubs.h	View	1	1 chunk	+0 lines, -70 lines	0 comments	Download
D	vm/ic_stubs_arm.cc	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
D	vm/ic_stubs_ia32.cc	View	1	1 chunk	+0 lines, -358 lines	0 comments	Download
D	vm/ic_stubs_ia32_test.cc	View	1 2 3 4	1 chunk	+0 lines, -205 lines	0 comments	Download
D	vm/ic_stubs_x64.cc	View	1	1 chunk	+0 lines, -42 lines	0 comments	Download
M	vm/instructions_ia32.h	View	1	1 chunk	+0 lines, -153 lines	0 comments	Download
M	vm/instructions_ia32.cc	View	1	1 chunk	+0 lines, -60 lines	0 comments	Download
M	vm/instructions_ia32_test.cc	View	1	3 chunks	+3 lines, -104 lines	0 comments	Download
M	vm/object.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	vm/object.cc	View	1	5 chunks	+14 lines, -36 lines	0 comments	Download
M	vm/raw_object.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	vm/stub_code.h	View	1 2 3 4 5 6 7	4 chunks	+3 lines, -5 lines	0 comments	Download
M	vm/stub_code.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	vm/stub_code_arm.cc	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	vm/stub_code_ia32.cc	View	1 2 3 4 5 6 7	2 chunks	+88 lines, -26 lines	0 comments	Download
M	vm/stub_code_x64.cc	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	vm/vm_sources.gypi	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2011/10/25 17:13:56, srdjan wrote: Added trace_ic printing in "InlineCacheMissHandler" (code_generator.cc).

9 years, 2 months ago (2011-10-25 17:58:33 UTC) #2

regis

LGTM Nice simplification! http://codereview.chromium.org/8379013/diff/7015/vm/code_generator.cc File vm/code_generator.cc (right): http://codereview.chromium.org/8379013/diff/7015/vm/code_generator.cc#newcode434 vm/code_generator.cc:434: // Handles inline cache misses bu ...

9 years, 2 months ago (2011-10-25 18:06:27 UTC) #3

srdjan

9 years, 2 months ago (2011-10-25 18:28:50 UTC) #4

http://codereview.chromium.org/8379013/diff/7015/vm/code_generator.cc
File vm/code_generator.cc (right):

http://codereview.chromium.org/8379013/diff/7015/vm/code_generator.cc#newcode434
vm/code_generator.cc:434: // Handles inline cache misses bu updating the IC data
array of the call
On 2011/10/25 18:06:27, regis wrote:
> bu -> by

Done.

http://codereview.chromium.org/8379013/diff/7015/vm/stub_code.h
File vm/stub_code.h (right):

http://codereview.chromium.org/8379013/diff/7015/vm/stub_code.h#newcode43
vm/stub_code.h:43: V(InlineCache1)                                              
               \
On 2011/10/25 18:06:27, regis wrote:
> I guess "1" means "check receiver only". Should you make the name more
> descriptive? Or just call it "InlineCache" and wait until you have more
flavors.

The 1 should denote one argument checked. Removing the number until 2 or more
checks have been added.

http://codereview.chromium.org/8379013/diff/7015/vm/stub_code_ia32.cc
File vm/stub_code_ia32.cc (right):

http://codereview.chromium.org/8379013/diff/7015/vm/stub_code_ia32.cc#newcode...
vm/stub_code_ia32.cc:1444: // Test if Smi -> load Smi class for camparison.
On 2011/10/25 18:06:27, regis wrote:
> I'd rather have an orange peel than a Smi in my campari...

:-) Done.

Expand Messages | Collapse Messages